fix(all): multiple warnings fix #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheoPascoli
force-pushed
the
fix/remove-some-deprecated-methods
branch
from
8ecc6b5 to
d43d9f9
Compare
TheoPascoli
force-pushed
the
fix/remove-some-deprecated-methods
branch
from
d43d9f9 to
d3c01ea
Compare
TheoPascoli
changed the title
…om/AntaresSimulatorTeam/AntaREST into fix/remove-some-deprecated-methods
…ated-methods # Conflicts: # antarest/tools/lib.py
| @@ -154,8 +154,8 @@ class LinkBaseDTO(AntaresBaseModel): | |||
| colorg: int = Field(default=DEFAULT_COLOR, ge=0, le=255) | |||
| link_width: float = 1 | |||
| link_style: LinkStyle = LinkStyle.PLAIN | |||
| filter_synthesis: t.Optional[comma_separated_enum_list] = FILTER_VALUES | |||
| filter_year_by_year: t.Optional[comma_separated_enum_list] = FILTER_VALUES | |||
| filter_synthesis: t.Optional[comma_separated_enum_list] = field(default_factory=lambda: FILTER_VALUES) | |||
There was a problem hiding this comment.
Does it work to use a dataclass field inside a Pydantic class ?
| return [] | ||
|
|
||
| filter_accepted_values = [e for e in enum_cls] | ||
| valid_values = {str(e.value) for e in enum_cls} |
There was a problem hiding this comment.
Don't think you need to do str() as e.value is already one
There was a problem hiding this comment.
I need it for mypy
|
|
||
| res_json = res.json() | ||
| assert res_json["exception"] == "LinkValidationError" | ||
| match = re.search(r"Allowed values are: (.*)\.", res_json["description"]) |
There was a problem hiding this comment.
The test seems a bit complex to me. If you can just check the res_json["description"] in an easier way I won't mind
There was a problem hiding this comment.
Indeed, however, the values "daily, hourly, etc" comes in random order at each test, I can not do a simple equal
…ated-methods # Conflicts: # antarest/study/business/area_management.py
sylvlecl
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multiple warnings and some stuff